Re: CVS: commit msevior abi/src/text/ptbl/xp pd_Document.cpp

On Sat, 2006-03-11 at 09:32 +1100, msevior@physics.unimelb.edu.au wrote:
> >
> >> PTL_UNKNOWN,
> >> - PTL_DocLayout
> >> + PTL_DocLayout,
> >> + PTL_CollabExport
> >> /* add more types here ONLY as necessary */
> >> } PLListenerType;
> >
> > Erm, are we adding *plugin* code to the AbiWord main tree now?
> >
>
> Yeah. We've done this lots of times before too

Yep I know... still doesn't make it a good excuse though :)

> . Let me know if ou can
> think of a different way to do this.

We have to make the design extend-able then IMO, instead of just dumping
things into the core of AbiWord. If we allow ourselves to do this, then
we can almost just as well dump all plugin stuff into the main tree.

I'm trying to make a start with dialogs in plugins, and to make plugin
strings translatable. The fact that the equation dialog for example is
in the main Abi tree is proof of a very bad design.

I'm afraid that if we continue this for a lil' while longer, we end up
with an unmaintablable mess.

I think for 2.6 it is time to do things the right way, and I hope to
have something to commit myself soonish.

Bye,
  Marc
Received on Sun Mar 12 18:15:08 2006