commit -- Re: Inserted image size

Matt Kimball (robozapp@xmission.com)
Wed, 26 May 1999 22:51:24 -0600


On Wed, May 26, 1999 at 09:50:48AM -0500, Eric W. Sink wrote:
> However, the real fix for bug 417 is to simply ignore the zoom
> factor when inserting an image. Image insert was coded before zoom,
> and it was designed to simply assume screen resolution when inserting
> the image. Unfortunately, the zoom code worked too well, altering
> the notion of screen resolution from the image insertion code's
> point of view. We can simply special-case that one, and bug 417
> will go away.

Ok, I just checked in code to do this. (And moved most of the
relevant code from fv_View.cpp to fg_GraphicRaster.cpp).

As I was testing, I noticed it would assert sometimes at the top of
fp_ImageRun::findPointCoords. It wasn't reliable; I couldn't get it
to happen while I was running AbiWord in gdb. Maybe I was doing
something slightly differnt though. It may be related to bug #407
too. I don't think I changed anything which would cause it.

> This will not address the real problems being raised on this thread,
> but it will effect the original [arguably broken] behavior which
> was intended.

I think the above behavior with the possibility of resize from within
AbiWord should be sufficient. Oh, it should probably look at pHYs
first too.

-- 
Matt Kimball
mkimball@xmission.com


This archive was generated by hypermail 1.03b2.