Re: msevior - r35470 - abiword/trunk/src/wp/impexp/xp

Hi,

Looks like line 9791 should also be patched to become:
                UT_std_string_removeProperty(sProps,sPropNameLatex);
instead of:
                UT_std_string_removeProperty(sProps,sPropName);

As I currently have other changes in this file currently, I'll not
commit that for now. I'm trying to fix #12401 but if things mostly work
now, I'm sometimes getting a crash with the original file and always
runtime errors such as:

fp_Line.cpp:1918:75: runtime error: downcast of address 0x5614fd707e00
which does not point to an object of type 'fp_Line'
0x5614fd707e00: note: object is of type 'fp_TableContainer'

Looks like we use inappropriately static_cast in some places.

Martin, happy to see you are back :-)

Jean

Le mercredi 04 juillet 2018 à 03:31 +0200, cvs@abisource.com a écrit :
> Author: msevior
> Date: 2018-07-04 03:31:45 +0200 (Wed, 04 Jul 2018)
> New Revision: 35470
>
> Modified:
> abiword/trunk/src/wp/impexp/xp/ie_imp_RTF.cpp
> Log:
>
> Fix crash copy and pasting equations.
>
>
>
> Modified: abiword/trunk/src/wp/impexp/xp/ie_imp_RTF.cpp
> ===================================================================
> --- abiword/trunk/src/wp/impexp/xp/ie_imp_RTF.cpp 2018-07-03
> 02:30:28 UTC (rev 35469)
> +++ abiword/trunk/src/wp/impexp/xp/ie_imp_RTF.cpp 2018-07-04
> 01:31:45 UTC (rev 35470)
> @@ -9778,8 +9778,8 @@
> std::string sPropName = "dataid";
> std::string sDataIDVal =
> UT_std_string_getPropVal(sProps,sPropName);
> UT_std_string_removeProperty(sProps, sPropName);
> - sPropName ="latexid";
> - std::string sLatexIDVal =
> UT_std_string_getPropVal(sProps,sPropName);
> + std::string sPropNameLatex ="latexid";
> + std::string sLatexIDVal =
> UT_std_string_getPropVal(sProps,sPropNameLatex);
>
> PP_PropertyVector attrs = {
> sPropName, sDataIDVal,
>
> -----------------------------------------------
> To unsubscribe from this list, send a message to
> abisource-cvs-commit-request@abisource.com with the word
> unsubscribe in the message body.
Received on Wed Jul 4 09:54:57 2018