Simon Larochelle wrote on Sat, 29 Oct 2011 13:07:22 -0400:
> I also looked into bug 13101 (line spacing has no effect, text always
> rendered with single line spacing). I tracked the problem to the
> function fp_Line::calcBorderThickness(void) which sets the line height
> without looking at the block properties. The fp_Line::setHeight()
> command in fp_Line::calcBorderThickness() was added in revision 28594
> (implementation of paragraph border drawing).
> Note that presently the program flow is
> 1) set line height in fp_Line::recalcHeight(fp_Run * pLastRun)
> 2) assign lines to a column in fb_ColumnBreaker::_breakSection(fp_Page
> * pStartPage)
> 3) set line height in fp_Line::calcBorderThickness(void)
> 4) set the position (m_iX and m_iY) of each line in
> fp_Column::layout(void)
> Clearly step 3 needs to be eliminated. Can we simply remove the line
> "setHeight(getAscent()+getDescent());" from
> fp_Line::calcBorderThickness setHeight() ?
I can confirm that removing this statement fixes the bug (which is IMO *the*
most annoying one, because it prevents using AbiWord as a text *processor*).
The remaining question however is, why is this statement? Selecting "Borders
and Shading" crashes AbiWord anyway.
Ingo
Received on Fri Nov 18 11:43:14 2011
This archive was generated by hypermail 2.1.8 : Fri Nov 18 2011 - 11:43:14 CET