Re: ib - r30466 - abiword/trunk/plugins/mswrite/xp

From: Hub Figuière <hfiguiere_at_teaser.fr>
Date: Fri Nov 18 2011 - 05:27:11 CET

On 17/11/11 10:50 AM, Ingo Brückl wrote:
>
> Hub Figuière wrote on Thu, 17 Nov 2011 10:28:58 -0800:
>
>> On 17/11/11 10:21 AM, cvs@abisource.com wrote:
>
>>> - if (process == All) UT_DEBUGMSG(("PAP:\n"));
>>> + if (process == All) { UT_DEBUGMSG(("PAP:\n")) };
>
>> Since you are at fixing the braces (good), please fix the indentation
>> too.
>
> Not for these one line debug messages. This would worsen readability.

I disagree. What worsen readability is a if without trailing block....

Maybe we actually need to introduce a UT_DEBUG_MSG() macro.

But still.

Hub
Received on Fri Nov 18 05:27:28 2011

This archive was generated by hypermail 2.1.8 : Fri Nov 18 2011 - 05:27:28 CET