Re: ib - r30529 - abiword/trunk/plugins/mswrite/xp

From: "Hub Figuière" <hfiguiere@teaser.fr>
Sent: Sunday, December 25, 2011 7:22 AM
To: <abiword-dev@abisource.com>
Subject: Re: ib - r30529 - abiword/trunk/plugins/mswrite/xp

>
>> AP_Args::m_impProps is a static buffer too, so it's rather equivalent.
>
> Does not matter. Whatever is returned by getProperty() gets put into a
> stack allocated std::string.
>

LOL. I meant that the code is already thread-unsafe because whichever we put into static buffer
::s_cpbuffer is coming directly from another static buffer at AP_Args::m_impProps, so if we replace ::s_cpbuffer with a class member, it will not make it thread-safe or yield different behavior.
 
Received on Sun Dec 25 02:57:31 2011