Re: PATCH: speed up GR_UnixPangoGraphics::shape()

Hi Robert,

Robert Wilhelm wrote:
> Hello Tomas,
>
> this patch is in reply to
> http://www.abisource.com/mailinglists/abiword-dev/2006/Feb/0081.html
>
> Some things take a while...

:) Probably about as long since I have contributed anything ...

> It avoids quadratic behavior and many calls to g_utf8_pointer_to_offset
> by iterating only one time through the string.

The patch looks good; getting rid of the g_utf8_pointer_to_offset() in
this case makes sense, I think (though I do not see how this change
avoids quadratic behaviour, as the while loop is equivalent of the
g_utf8_pointer_to_offset() function call).

Tomas
Received on Tue Jul 14 18:15:28 2009