Re: PATCH: speed up GR_UnixPangoGraphics::shape()

Hi Robert,
               I totally agree! Feel free to put some comments
elsewhere in the pango cairo graphics class too.

Right now only Tomas Frydrich understands what is actually happening
in many places. we need to get that knowledge more widely spread.

For example we have a bug report that Arabic shaping breaks after
apostrophe characters. If more developers understood the class we
could get more brain power working on why this happens and fix it.

Cheers

Martin

On Tue, Jul 14, 2009 at 8:41 AM, J.M. Maurer<uwog@uwog.net> wrote:
>
> On Mon, 2009-07-13 at 21:41 +0200, Robert Wilhelm wrote:
>> Hello Tomas,
>>
>> this patch is in reply to
>> http://www.abisource.com/mailinglists/abiword-dev/2006/Feb/0081.html
>>
>> Some things take a while...
>>
>> It avoids quadratic behavior and many calls to g_utf8_pointer_to_offset
>> by iterating only one time through the string.
>
> Since I'm mostly clueless on what our shaper does, would you be so kind
> to add some comments in the patch explaining what we actually try to do
> here?
>
> In the distant future I hope to get some of this, and some comments in
> there would go a long way :)
>
> Rockin' work Robert!
>
>  Marc
>
>
Received on Tue Jul 14 01:42:19 2009