On Tue, 2008-07-29 at 04:55 +0200, cvs@abisource.com wrote:
>
>
> Modified:
> abiword/trunk/plugins/collab/core/packet/xp/AbiCollab_Packet.cpp
> ===================================================================
> ---
> abiword/trunk/plugins/collab/core/packet/xp/AbiCollab_Packet.cpp 2008-07-28 21:06:40 UTC (rev 24543)
> +++
> abiword/trunk/plugins/collab/core/packet/xp/AbiCollab_Packet.cpp 2008-07-29 02:54:58 UTC (rev 24544)
> @@ -75,7 +75,8 @@
> PT_IMAGE_DESCRIPTION,
> PT_DATA_PREVIEW,
> PT_HYPERLINK_TARGET_NAME,
> - PT_ANNOTATION_NUMBER
> + PT_ANNOTATION_NUMBER,
> + PT_AUTHOR_NAME
> };
>
> UT_sint16 getPacket_PTName_Index( const gchar* name )
Ok, I had typed this response:
======
This change breaks the protocol. Whenever such change is made, the
protocol version should be bumped so users are informed that they can
not collaborate with eachother, and should update their copy of abiword.
Thinking of it: this change can be called 'backwards compatible': a
client can ignore the new property if it wants: since we don't store it
in the document, we don't have any 'dataloss'. We don't have a mechanism
to denote that yet though.
======
But thinking of it (these questions can be stupid, but that's because I
don't see how it actually works right now :)
1. why is it called 'author name' ? what does it contain, and int, an
uuid, or an actual name?
2. why is it transmitted over the wire? Isn't it a property that the
receiving side can add itself?
Marc
Received on Mon Aug 4 12:32:42 2008
This archive was generated by hypermail 2.1.8 : Mon Aug 04 2008 - 12:32:42 CEST