On Wed, 2007-07-11 at 17:22 +0200, Jordi Mas wrote:
>
> En/na J.M. Maurer ha escrit:
> > On Wed, 2007-07-11 at 08:54 +0200, cvs@abisource.com wrote:
> >> Fixes Ryan Pavlik problem regarding AbiCollab dialog boxes. I'm
> >> overriting the previous patch since I belive mine is more elaborate.
> >
> > Erm, RP's version was always correct; Yours is only correct if someone
> > doesn't screw up the dialog ordering. How is that better?
>
> There is piece of code in DEBUG mode that makes sure that order is right, if
> it is not it does fires an ASSERT. That prevents the problem from happing
> again. In my version, I do not need to compare as many times and as elements
> are in release mode to find out the next element. I prefer to make an effort
> that to waste user's CPU cycles.
So the 65 integer compares are the problem? Or am I missing something
really obvious?
I guess my issue with your solution is that it only is guaranteed to
work if someone happens to test a debug version, notices the error, and
actually fixes it. If no debug version is tested before a release, then
the behavior might be wrong. This all to save 65 int compares.
Marc
Received on Wed Jul 11 17:45:37 2007
This archive was generated by hypermail 2.1.8 : Wed Jul 11 2007 - 17:45:38 CEST