Re: wv Patch: fix word import crashes

From: Hubert Figuiere (hfiguiere_at_teaser.fr)
Date: Mon Mar 08 2004 - 17:27:03 EST

  • Next message: Marc Maurer: "Commit (STABLE): Re: commit: fix crash bug 6332,"

    On Mon, 2004-03-08 at 21:00, Robert Wilhelm wrote:
    > Today I was able to trace the reason of all these "AbiWord 2.0.3"
    > crashes on Windows during import of Word dokument:
    >
    > The stylesheet.c patch which some unamed abi hacker commited on 1.1.2004
    > seems to be utterly broken:
    >
    > - b is initialized in every iteration of the loop.
    > - item->xstzName is used in strncat without initialising it.
    > - the terminating null is not taken into account when checking
    > if there is enough space
    > - the third argument to strncat is the maximum number of chars to be
    > concated, not the maximum result lenght.
    >
    > I have appended a patch.

    Nice catch.

    OK. I am guilty. But the bug is around for quite some time, AND I
    remember having asked review first.

    Robert, I owe you a beer (or whatever beverage you favor). And also one
    to uwog and dom and all the folks :-/
    As we say in French: "Patron, c'est ma tournée !"

    Hub

    This archive was generated by hypermail 2.1.4 : Mon Mar 08 2004 - 17:28:20 EST