Re: Latest ispell commit broke the build

From: Gabriel Gerhardsson (mr.g@home.se)
Date: Sun Oct 20 2002 - 08:31:36 EDT

  • Next message: Ivica Bogosavljevic: "Cyrillic and Latin Serbian translation"

    On Sun, 2002-10-20 at 11:25, Jordi Mas wrote:
    >
    > > Looking at ispell_checker.h, it looks as if getMapping has been redeclared to virtual,
    > > while the hash
    > > downloader is still expecting a static function. Could you fix this ASAP, Jordi? I don't
    > > want to
    > > step on your
    > > toes (moreover, I'm feeling kinda lazy today).
    >
    > This function is longer static due to all the new needs. I think that the best
    > is that you create an object and then call the getMapping() member. Please,
    > can you do this? I have not your platform and I cannot test if this will work
    > or not.

    Fixed.
    But why isn't there a global instantiation of ISpellChecker for every
    frame? To have to create a new one all the time seems wasteful to me. Oh
    well.

    Take care
    /Gabriel

    CVS:
    ----------------------------------------------------------------------
    CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    CVS:
    CVS: Committing in .
    CVS:
    CVS: Modified Files:
    CVS: src/af/xap/xp/xap_HashDownloader.cpp
    CVS: src/other/spell/xp/ispell_checker.h
    CVS: src/wp/ap/xp/ap_HashDownloader.cpp
    CVS:
    ----------------------------------------------------------------------

    This archive was generated by hypermail 2.1.4 : Sun Oct 20 2002 - 08:46:43 EDT