Subject: Re: Code Cleanup
From: Thomas Fletcher (thomasf@qnx.com)
Date: Wed Jan 17 2001 - 19:53:31 CST
On Wed, 17 Jan 2001, Michael D. Pritchett wrote:
> From: Thomas Fletcher <thomasf@qnx.com>
> > On Wed, 17 Jan 2001, Thomas Briggs wrote:
> >
> > >
> > > This patch looks good, compiles ok and seems to work for me on
> Windows.
> > > Anybody in the Unix world wanna test this out or should I just go ahead
> and
> > > commit it?
> >
> > I read through the patch and it seemed fine to me ... but I haven't had
> > a chance to apply it ... though when it is applied I'll have to fix the
> > QNX build (in the future if something like this changes I'd appreciate
> > just sticking a #error "Update me!" in the code to guarantee the update).
> >
>
> Thomas - nothing should have broken on the QNX build and therefore I don't
> see a need for an "#error Update me!" message.
Michael,
No I realize that ... while it would not have broken anything,
it does mean that some platforms do something different from
other platforms. Now imagine that you want to tweak or fix
the generic stuff ... people who didn't make the change in the
first place (perhaps for a good reason ... more likely because
it fell between the cracks) don't get it. Several months down
the road they are left trying to debug why one platform is
messing up and another is not.
This is currently happening to me right now. At some point
in time when the focus stuff originally went in there were
changes made to the wp/ap/{win,unix}/*Frame.cpp in order to
carry the focus mode from the existing view to the next. This
change never got placed into the QNX code and as a result I
had the odd behaviour (on QNX only) that when you used the
Zoom dialog things were fine, but if you used the zoom on
the toolbar then things didn't work and you had to un-focus the
window and re-focus it before you could type or use the mouse
etc.
All it took was one line of code ... which was generic
on all platforms ... to be carried over to the QNX port.
I'm not bitter at all (ok maybe a bit since this happens
all the time =;-) it is just that things get lost in the
noise of the list since my coding time isn't always in
conjunction with the time that I read my abiword developer
mailing lists.
Something that stopped my compile dead when I cvs updated
is going to get my attention. If that is too drastic,
then putting in a UT_DEBUGMSG(("TODO: blah blah blah \n")),
would also work.
Thanks,
ThomasF (just to differ from Thomas)
This archive was generated by hypermail 2b25 : Wed Jan 17 2001 - 19:54:02 CST